cnabio / cnab-go

A Go implementation of CNAB Core 1.0

MIT License

69 stars 37 forks source link

Allow non-integer numbers in bundle.json #248

Closed carolynvs closed 3 years ago

carolynvs commented 3 years ago

Now that we have switched to a canonical json library that supports non-integer numbers, I've updated the bundle.json definition to use float for: maximum, mimimum and multipleof.

The tests now use non-integer numbers to validate that a bundle using values like 5.5 can be marshaled now.

🛑 This relies on #247 and upstream changes to the schemas in cnab-spec. Once that is merged and the spec tagged with a patch release, I'll rebase.

radu-matei commented 3 years ago

247 was merged, I think this only needs a rebase now?

carolynvs commented 3 years ago

@radu-matei the tests won't pass until the spec is tagged. It is comparing my changes against the current spec, and so it's failing. Once I get Butcher's 👍 on the new release, then I can kick the build on this and it should be green.

carolynvs commented 3 years ago

/brig run

carolynvs commented 3 years ago

@radu-matei @vdice Okay, the spec change has been merged. This is ready for review.