search

cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 35 forks source link

Require only one review for pull requests to the cnab-go library #258

Closed carolynvs closed 3 years ago

carolynvs commented 3 years ago

We are having a hard time lately getting pull request reviews in a reasonable amount of time. @vdice and I discussed this in today's CNAB meeting and would like to propose that we only require a single review in this repository (spec still gets 2 reviews).

Would the maintainers please reply with a +1 if you agree?

technosophos commented 3 years ago

+1 - We have definitely done this in the past with other projects in order to fine-tune velocity. In this case, I think it is 💯 justified.

carolynvs commented 3 years ago

@technosophos How many votes do you think we need to make the change? So far we have you, myself, Radu, and Vaughn voting in favor.

technosophos commented 3 years ago

I would imagine simple majority would do.

carolynvs commented 3 years ago

Ok, there are 8 people in the codeowners file, so just 1 more to go! 🍿

glyn commented 3 years ago

+1

On Wed, 26 May 2021, 22:55 Carolyn Van Slyck, @.***> wrote:

Assigned #258 https://github.com/cnabio/cnab-go/issues/258 to @glyn https://github.com/glyn.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/cnabio/cnab-go/issues/258#event-4802144469, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXF2IRRQAU5VGPQT77UPLTPVU2FANCNFSM45SNC5XA .

chris-crone commented 3 years ago

SGTM!

+1

scottbuckel commented 3 years ago

+1!

silvin-lubecki commented 3 years ago

LGTM 👍

carolynvs commented 3 years ago

I'll update the GitHub settings to only require a single review. So say we all. Thanks everyone!