cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 35 forks source link

Don't log a warning about log streaming before the container has started #271

Closed carolynvs closed 2 years ago

carolynvs commented 2 years ago

Right now the kubernetes driver logs a warning each time that it tries to stream the logs, including when the container for the invocation image hasn't started yet. This adds noise to the output. It would be preferable if we didn't log warnings when the logs aren't available for expected reasons, and only logged when it's abnormal (like the container couldn't start).

Could not stream logs for pod install-llama-bc4sl-7dw6f. Retrying...: container "invocation" in pod "install-llama-bc4sl-7dw6f" is waiting to start: ContainerCreating
Could not stream logs for pod install-llama-bc4sl-7dw6f. Retrying...: container "invocation" in pod "install-llama-bc4sl-7dw6f" is waiting to start: ContainerCreating
executing install action from hello-llama (installation: llama)
Hello, quickstart
execution completed successfully!