cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 35 forks source link

Fix panic when op.Err is unset in Docker driver #280

Closed carolynvs closed 2 years ago

carolynvs commented 2 years ago

The op.Err field was added after the docker driver was first written. I noticed that when the caller of the docker driver doesn't set op.Err it causes a panic when we attach to the container's logs.

This fixes our defaulting of where we write errors so that we are never writing to a nil writer accidentally.

~It is based on #279 so I will rebase after that is merged.~