search

cnabio / cnab-spec

Cloud Native Application Bundle Specification
https://cnab.io
Other
958 stars 99 forks source link

ref(bundle.schema.json): remove pattern property from param/cred path #330

Closed vdice closed 4 years ago

vdice commented 4 years ago

Removes the pattern property from the definitions for parameters and credentials.

The negative lookup regex used proved problematic for validation (namely, incompatible with golang implementations, of which cnab's most-used - https://github.com/cnabio/cnab-go - is one).

This change would therefore mean implementations are responsible for enforcing spec expectations as regards these path strings, namely, "Specified path MUST NOT be a subpath of /cnab/app/outputs." as seen in https://github.com/cnabio/cnab-spec/blob/master/101-bundle-json.md.

Potential solution to https://github.com/cnabio/cnab-spec/issues/215

Corresponding cnab-go implementation: https://github.com/cnabio/cnab-go/pull/180

vdice commented 4 years ago

@technosophos I added this to the CNAB Core 1.1.0 milestone. Assuming it gains consensus, it can be merged to master in the meantime, correct? I think CNAB Core 1.0.1 is itself still pending (requires a vote), so I'm not sure what the 1.1.0 timeline would be.

technosophos commented 4 years ago

@vdice My reading of our versioning is that this is not a change to the specification, properly speaking. So we can merge it into 1.0.1 if you would like.