search

cnabio / cnab-spec

Cloud Native Application Bundle Specification
https://cnab.io
Other
956 stars 99 forks source link

Add parameter sources custom extension #365

Closed carolynvs closed 4 years ago

carolynvs commented 4 years ago

This custom extension defines how a runtime may connect outputs back to parameters. It is terribly useful in reducing user input but is also necessary now that we don't store the entire contents of outputs in the claim anymore. It gives authors a way to signal to runtimes when an output matters and when it should be injected back into a bundle and on which actions.

silvin-lubecki commented 4 years ago

@carolynvs there's a DCO issue with your last "Fix typo" commit 🐱

carolynvs commented 4 years ago

Yeah I'm fixing the remaining comments manually so that I can signoff. 😀

carolynvs commented 4 years ago

@silvin-lubecki About relocation maps

If I remember correctly cnabio/cnab-go#94 (review) we removed relocation maps from claims

That change was in the cnab-go implementation, doesn't look like relocation maps were ever in the claims spec, and we were stuffing it into a top level property at the time (using additionalProperties=true) and that was what was removed? Since relocation files are part of the core spec and are important to have supported properly in the claim, how about you submit a PR that adds the relocation-mapping data as a top level field to claim officially? Then we can add it back to the cnab-go implementation. How does that sound?

carolynvs commented 4 years ago

@vdice Sorry for the delay, I just pushed up the schema for parameter sources and added validation against an example.

vdice commented 4 years ago

/brig run

carolynvs commented 4 years ago

@jlegrone PTAL, I have incorporated your feedback into the PR. Some parts about the runtime were omitted because they were already defined in the core spec.