search

cnabio / cnab-spec

Cloud Native Application Bundle Specification
https://cnab.io
Other
958 stars 99 forks source link

Inconsistent spelling of canceled state #412

Closed carolynvs closed 3 years ago

carolynvs commented 3 years ago

In the spec we consistently use the spelling cancelled. However in cnab-go we have been using the alternative spelling canceled when we store state on the claim.

We should pick a spelling (british vs american) and use the same one everywhere. I lean towards sticking with canceled since that's what is stored in user's data right now, and update the spec to fix the misspelling.

carolynvs commented 3 years ago

Sounds like @jlegrone is also using canceled so I suggest that we update the spec to use this variation of the word, treating this as a typo. @chris-crone? @technosophos?

chris-crone commented 3 years ago

I think we should ideally move to canceled (US spelling) as this is more consistent with tooling like Golang. We should check that we aren't breaking people though.

carolynvs commented 3 years ago

Anyone using cnab-go won't be affected by the change (duffle, porter, data dog). I'm not aware of any other implementations right now. I'll ask on our Slack channel.