search

cnabio / cnab-spec

Cloud Native Application Bundle Specification
https://cnab.io
Other
957 stars 99 forks source link

Allow numbers again #414

Closed carolynvs closed 3 years ago

carolynvs commented 3 years ago

Revert the changes in #257 which updated the spec to disallow non-integer values. We misunderstood the canonical json spec and were using a library that didn't support numbers.

I have an open PRs for cnab-go which tested out switching to a library that support numbers in canonical json and it works great.

So now fields such as default, maximum, minimum, etc can use numbers again! 🎉

Closes #413

carolynvs commented 3 years ago

@technosophos @chris-crone I believe this would be a patch to the spec version? I think we will want to bump the spec version after this is merged.

carolynvs commented 3 years ago

I'll submit a PR to signy as I already went through the switch for cnab-go.

Here are the follow-up PRs to this spec change for cnab-go: https://github.com/cnabio/cnab-go/pull/247 https://github.com/cnabio/cnab-go/pull/248

chris-crone commented 3 years ago

@technosophos @chris-crone I believe this would be a patch to the spec version? I think we will want to bump the spec version after this is merged.

This doesn't break the existing interpretation so I agree!