cnabio / cnab-to-oci

Tool to convert CNAB bundle.json to OCI index
Apache License 2.0
54 stars 43 forks source link

The media type used doesn't meet the OCI artifact spec #100

Open ywk253100 opened 4 years ago

ywk253100 commented 4 years ago

The media type of CNAB config artifact is application/vnd.cnab.config.v1+json which doesn't meet the OCI artifact spec standard for the unique type: application/vnd.[org|company].[objectType].[optionalSubType].config.[version]+json

How about add a cncf section: application/vnd.cncf.cnab.config.v1+json?

technosophos commented 4 years ago

The organization that owns CNAB-to-OCI is the CNAB Foundation, which is an official foundation from JDF. (For those keeping track... LF has both CNCF and JDF under it, and CNAB Foundation is under JDF, but CNAB itself is not under CNCF.)

I suppose we could make it application/vnd.cnab.bundle.config.v1+json?

ywk253100 commented 4 years ago

The CNAB is also the artifact type, is it correct? If it it, maybe application/vnd.cnab.cnab.config.v1+json makes more sense?

carolynvs commented 4 years ago

I like @technosophos's suggestion. CNAB is the spec/foundation, and bundle is one of the artifacts in the spec (for example another artifact would be a claim). The double cnab would be confusing. 😀

technosophos commented 4 years ago

Just to clarify something that came up in Slack: CNAB Foundation is the foundation that maintains the CNAB specification. JDF is NOT the foundation that maintains the spec. So vnd.jdf.... is not correct. The IP for CNAB belongs to the CNAB Foundation.

chris-crone commented 4 years ago

I'm +1 to @technosophos's proposal