search

cnabio / cnab-to-oci

Tool to convert CNAB bundle.json to OCI index
Apache License 2.0
54 stars 41 forks source link

Configurable annotations for for the index #40

Closed radu-matei closed 5 years ago

radu-matei commented 5 years ago

Looking at the raw index that this library generates, the first question I have is whether we can have support for configurable annotations - specifically, I'm looking at:

"io.docker.app.format": "cnab",
"io.docker.type": "app",

Does Docker App have a strong dependency on these two annotations?

Thanks!

chris-crone commented 5 years ago

the first question I have is whether we can have support for configurable annotations

Yes, we should definitely add this.

Does Docker App have a strong dependency on these two annotations?

I believe they're used by our registries but they shouldn't be hard coded here.

radu-matei commented 5 years ago

Nice, thanks a lot for the response, Chris.

Leaving this open so we can better track. Thanks!