search

cnabio / cnab-to-oci

Tool to convert CNAB bundle.json to OCI index
Apache License 2.0
54 stars 41 forks source link

Push images if not present in registry #67

Closed radu-matei closed 5 years ago

radu-matei commented 5 years ago

I've been going back and forth over this for the last couple of weeks - consider the following scenario - a bundle was just built locally, and the images have not been pushed - before calling cnab-to-oci to push the bundle, runtimes must first push the images to a repository. Then, cnab-to-oci copies those images to a new repository, which is rather inefficient.

Do people have strong opinions against pushing images? I guess a sane workflow would be to checking if the image exists remotely and trying to copy (current behaviour), then fall back to tagging it accordingly and pushing it to the target repository.

Thoughts?

squillace commented 5 years ago

Wait, I'm not clear on the downside of... whatever it is that we are proposing to do here? an upsert push? What's the downside?

eunomie commented 5 years ago

I think #76 and #78 are fixing this issue, WDYT?