search

cnabio / cnab-to-oci

Tool to convert CNAB bundle.json to OCI index
Apache License 2.0
54 stars 41 forks source link

Update circleci configuration #95

Closed silvin-lubecki closed 4 years ago

silvin-lubecki commented 4 years ago

image

carolynvs commented 4 years ago

Does circle need to be reconfigured to know about the new location of the repository?

silvin-lubecki commented 4 years ago

That's what I thought too @carolynvs but I think the issue here with this circleci check that is continuously waiting is that circle ci is not approved by the cnabio organization 🤔 That said, with @radu-matei we think that we should move to github actions, but maybe that's something we should decide at an organization level so every repository would have the same CI structure? We can discuss that point at the next CNAB community meeting. 👍

carolynvs commented 4 years ago

I am happy to approve circle until we get it figured out, no need to go without CI while we decide. Do you want to send a request? I just checked at the org level and didn't see anything pending.

radu-matei commented 4 years ago

If enabling Circle for the organization is not a big decision, then I'd be much more comfortable doing that until we can have a community decision about switching CI systems. (I am definitely in favor of moving to GH actions though).

radu-matei commented 4 years ago

It turns out Circle is actually running the builds (since the repo was moved), but it is not reporting the results back to GitHub (probably because it is not authorized) - https://circleci.com/gh/cnabio/cnab-to-oci/300

vdice commented 4 years ago

When I navigate to the org settings according to https://circleci.com/docs/2.0/enable-checks/, I encounter the following error: Screen Shot 2020-02-14 at 9 05 38 AM

I think perhaps @silvin-lubecki or @radu-matei should have permissions to add the GH app, as I am not yet a maintainer on this specific repo.

radu-matei commented 4 years ago

I see the same error as @vdice here. This might already be more of a headache than just using something already enabled..

vdice commented 4 years ago

Oh, when I refreshed the page, it showed the enable button, etc. I believe it is added now (currently just to this one repo.) Try to trigger with a new push @silvin-lubecki ?

silvin-lubecki commented 4 years ago

Supersed by #97 , rebased so now just bumping golang and adding circle ci badge, PTAL 🙏