search

cnabio / cnab-to-oci

Tool to convert CNAB bundle.json to OCI index
Apache License 2.0
54 stars 41 forks source link

feat(ci): add release job #97

Closed vdice closed 4 years ago

vdice commented 4 years ago

Adding in Draft as I'm a circleci newbie! Cobbled together after quick looks at docs/examples... Perhaps @silvin-lubecki can lend a hand in review/testing/etc. ?

TODO:

Contributes towards https://github.com/cnabio/cnab-to-oci/issues/90

vdice commented 4 years ago

@silvin-lubecki my attempts at testing on my fork have been thwarted by failures in the initial build job, as in https://circleci.com/gh/vdice/cnab-to-oci/4. I'm also unable to run make all-ci locally successfully 😅 ... edit: oh, need to update import paths, etc., as is done in https://github.com/cnabio/cnab-to-oci/pull/95

vdice commented 4 years ago

@silvin-lubecki this should be ready to re-test once some of the dependent PRs are merged (https://github.com/cnabio/cnab-to-oci/pull/95, https://github.com/cnabio/cnab-to-oci/pull/97)... let's check back in when ready and I can rebase, etc.

vdice commented 4 years ago

😱 I think it's working! Note the new main CircleCI GH Check and link. We should be good to now remove the old status webhook (ci/circleci: build) from https://github.com/cnabio/cnab-to-oci/settings/hooks. <-- I'll defer to @radu-matei or @silvin-lubecki to do so.

Turns out it appears that enabling workflows are a prereq for GH checks, hence the addition in this PR:

Screen Shot 2020-02-14 at 12 22 05 PM

vdice commented 4 years ago

As for testing the new release job... I'll need pointers from those more familiar w/ CircleCI on how to test before an actual tag push. Or, we just test it live on the next tag push and adjust if need be 😅 .

The configuration looks good according to https://circleci.com/blog/publishing-to-github-releases-via-circleci/#plain-circleci-2.0-example

silvin-lubecki commented 4 years ago

@vdice I removed the old check and added the main one as required. Thank you so much for investigating this 👍

silvin-lubecki commented 4 years ago

Oh crap I should have squashed before merging 🤦‍♂

vdice commented 4 years ago

Oops! My fault for not condensing commits beforehand 😅 .