cnabio / duffle

CNAB installer
https://duffle.sh
MIT License
376 stars 54 forks source link

Add `duffle claim show --output` #815

Closed astrieanna closed 5 years ago

astrieanna commented 5 years ago

Part of https://github.com/deislabs/duffle/issues/747

After making the code compile against the cnab-go library with outputs support implemented, this PR adds a --output flag to duffle claim show. This allows users to dump the contents of output files to stdout.

cc @youreddy @jeremyrickard

astrieanna commented 5 years ago

@silvin-lubecki does this side of the PR look good?

radu-matei commented 5 years ago

/brig run

youreddy commented 5 years ago

The PR in cnab-go was merged, going to update the Gopkg.toml file to point to the updated version!

jeremyrickard commented 5 years ago

@youreddy should we release cnab-go or are you planning on pinning to a commit #? I'd prefer a released version, but we can always update to that once we have a few more things in.

youreddy commented 5 years ago

@jeremyrickard, I was going to specify master but you're right we should do a released version. And yes to releasing cnab-go!

jeremyrickard commented 5 years ago

/brig run

astrieanna commented 5 years ago

@jeremyrickard /brig run ?

radu-matei commented 5 years ago

/brig run

jeremyrickard commented 5 years ago

@astrieanna sorry for the delayed response. Were you asking me to re-run it, or what "/brig run" does? Happy to explain what it does if you'd like!

jeremyrickard commented 5 years ago

/brig run

jeremyrickard commented 5 years ago

Thanks for the persistence on this @astrieanna and @youreddy, much appreciated.