cnabio / duffle

CNAB installer
https://duffle.sh
MIT License
375 stars 54 forks source link

duffle version returns the commit even with a "release" name #850

Open squillace opened 5 years ago

squillace commented 5 years ago

for https://github.com/deislabs/duffle/releases/tag/0.3.2-beta.1, for which there is a formal "release name", the command duffle version merely lists the commit. This is fine for developers of duffle, but for general users, release names should be of the form "release-name (commit)"

 🔋 55% (1:19)  duffle version                                                                                          ✔  8877  15:53:56
44aad89
radu-matei commented 5 years ago

https://github.com/deislabs/duffle/blob/44aad89f21eec35fbb6b1400e33ed4e1a565a361/Makefile#L11