search

cnabio / duffle

CNAB installer
https://duffle.sh
MIT License
376 stars 54 forks source link

Start using "v" prefix for tags #865

Open glyn opened 5 years ago

glyn commented 5 years ago

This is for consistency with cnab-go.

Also https://semver.org/spec/v1.0.0.html#tagging-specification-semvertag favours this:

When tagging releases in a version control system, the tag for a version MUST be “vX.Y.Z” e.g. “v3.1.0”.

thaney071 commented 4 years ago

Your developer guide page points to the semversion 2.0.0 webpage, but your issue is for a 1.0.0 part of the spec. 2.0.0 has removed this suggestion and now has this in the FAQ: https://semver.org/#is-v123-a-semantic-version

If you are intending to use semver 1.0.0, then the link might need to be updated. Otherwise, it would be better to state this is for consistency with other parts of the cnab project.

carolynvs commented 4 years ago

@thaney071 Correct, as Glyn said we would like to be consistent with the other cnabio projects which use the v prefix for our git tags.

We do follow semver 2 for the CNAB spec for bundle version by the way, the bundle.json version field doesn't use a v prefix. This issue is only applicable to the git tag for this repo.