search

cnap / gec-ranking

Data and code used in the 2015 ACL paper, "Ground Truth for Grammatical Error Correction Metrics"
51 stars 7 forks source link

Allowing import and py3 compatabillity #1

Open borgr opened 6 years ago

borgr commented 6 years ago

Hi, The changes are not large and only affect the code (nothing in the logic is changed).

  1. fixed a bug of not closing files
  2. allowed to be run on py3
  3. moved the main calculation into a function from main so import would be possible
  4. PEP08
  5. historical typo (BLEU instead of GLEU)
  6. the name of the project is not so great at '-' can't be a part of a python module name, I would change it into a '_' if I were you, but its up to you.