improved Escher integration

cnapy-org / CNApy

An integrated visual environment for metabolic modeling with common methods such as FBA, FVA and Elementary Flux Modes, and advanced features such as thermodynamic methods, extended Minimal Cut Sets, OptKnock, RobustKnock, OptCouple and more!

https://cnapy-org.github.io/CNApy-guide/

Apache License 2.0

44 stars 7 forks source link

improved Escher integration #513

Closed axelvonkamp closed 2 months ago

axelvonkamp commented 3 months ago

reactions can be deleted via the tooltip
reaction/metabolite ID changes are propagated to Escher map
reaction stoichiometry changes are propagated (no removal or addition of metabolites though)
use signal/slot where possible instead of runJavaScript

sthiele commented 2 months ago

I find the red cross in the upper left corner confusing because it reminds me of the close button in windows. Maybe use a trash can? One can only wipe reactions from the canvas, I fear that this may cause undesired removals. Without an undo operation, maybe add a confirmation dialog?

axelvonkamp commented 2 months ago

Yes, maybe a different symbol might be better. The tooltip says "Remove from map" so I was hoping this would be sufficient. The action actually is undoable, but for this you need to enter the edit mode.