search

cnaude / PurpleIRC-forge

Minecraft Forge mod IRC relay.
2 stars 2 forks source link

Forge receives chat but doesn't send #1

Closed Rhodizzle closed 9 years ago

Rhodizzle commented 9 years ago

Hi cnaude, I'm using this mod on a custom forge server to link chat together with my 1.8 spigot server. The 1.8 mod is working flawlessly, however the forge version is not sending regular chat to IRC. Player joins/leaves go through and players can use /irc send X to send messages to IRC, but their default chat isn't getting relayed. I have no errors anywhere to give you, even trying to put it into debug mode.

Anything else I can do to help?

cnaude commented 9 years ago

What does debug mode print anything at all?

cnaude commented 9 years ago

Can I get a list of the mods you are running and the exact version of forge?

Rhodizzle commented 9 years ago

Debug mode doesn't seem to print anything regarding chat not being forwarded.

Here's the modlist: http://www.technicpack.net/modpack/antivanilla2.628815/mods.

It's a kitchen sink mod :)

Rhodizzle commented 9 years ago

Does debug mode output to console or a log file? Also, forge 10.13.3.1384.

cnaude commented 9 years ago

It depends on how your server is configured. If you have a custom log4j it might end up somewhere else. Otherwise on a plain forge server it would appear in the main log.

Rhodizzle commented 9 years ago

Ah, found the debug logs in the FML logs. Give me a few minutes to get my client reconnected and test it again...

Rhodizzle commented 9 years ago

So, when I chat on the forge server, I get nothing whatsoever in the purpleIRC chat logs.

If I chat in the IRC Channel directly, I get this on the Forge Server: [20:11:00] [listenerPool0-thread804/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Message caught : test [20:11:00] [listenerPool0-thread804/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] processMessage: test [20:11:00] [listenerPool0-thread804/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Message dispatched for broadcast... [20:11:00] [listenerPool0-thread804/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Checking if irc-chat is enabled before broadcasting chat from IRC [20:11:00] [listenerPool0-thread804/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Yup we can broadcast due to irc-chat enabled [20:11:00] [listenerPool0-thread804/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Checking for exact player matching Rhodizzle [20:11:00] [listenerPool0-thread804/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] [P]Raw message: [ǴIRCȲ]<%NAME%> %MESSAGE% [20:11:00] [listenerPool0-thread804/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] customPrefix before: [IRC] [20:11:00] [listenerPool0-thread804/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] customPrefix after: [IRC] [20:11:00] [listenerPool0-thread804/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Filtering AwesomeBot from [ǴIRCȲ] test

If I chat in the 1.8 server, I get this in the forge server: [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Message caught : hey Rhodizzle [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] processMessage: hey Rhodizzle [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Message dispatched for broadcast... [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Checking if irc-chat is enabled before broadcasting chat from IRC [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Yup we can broadcast due to irc-chat enabled [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Checking for exact player matching AlmostVanilla [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] ircChatToGameTokenizer: null player: AlmostVanilla [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Tokenizing AlmostVanilla [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] player: null [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] playerTokenizer: 7 [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] [S]Raw message: [ǴIRCȲ]<%NAME%> %MESSAGE% [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] customPrefix before: [IRC] [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] customPrefix after: [IRC] [20:13:16] [listenerPool0-thread828/DEBUG] [PurpleIRC/PurpleIRC]: [DEBUG] Filtering AwesomeBot from [ǴIRCȲ] hey Rhodizzle

cnaude commented 9 years ago

I'll need to add some additional debug messages to see where it is failing.

Rhodizzle commented 9 years ago

Ok. Drop me a note here when you want me to test with a new version. Noob question: is there an easy way to build from source off of your git repository? I have version 15 installed which is the latest on curse, but the debug says there is a version 17 when it does the update checks. Does the update check git or another source?

cnaude commented 9 years ago

The update checker currently checks http://h.cnaude.org:8081/job/PurpleIRC-forge/ Build 18 has the extra debugging. Building from source is not quite simple. I can probably add the instructions to the readme.

Rhodizzle commented 9 years ago

Ah ok, I'll bookmark the Jenkins link. I don't have any need to build from source, just couldn't find the .jars other than on curse.

cnaude commented 9 years ago

Is there an easy way for me to fire up a server with all the mods you use? Then I can test it myself.

Rhodizzle commented 9 years ago

I wouldn't call it easy. If you install Technic and log in then put this full url in the search bar "http://www.technicpack.net/modpack/antivanilla2.628815" it will find our AntiVanilla2 modpack. Once you install that, you can copy the mods and configs from the technic directory over to the forge server that you have. As a reminder, we're running Forge 10.13.3.1384. Remove CustomMainMenu and ResourceLoader as they are client only mods (don't need to worry about configs, just the jar in the mods folder.)

Just got the -18 test up and running, no change. The DEBUG logs aren't firing at all with normal chat and I also noticed that the /irc send TEXT command doesn't work from the console. I know absolutely zero about mod development for forge, but my programming background makes it feel like there is an issue with the hook into forge chat, probably caused by another mod. I'll try running the server with purpleIRC only and see if there are still issues as well.

Rhodizzle commented 9 years ago

Definitely a mod conflict, just not sure how to figure out which one is causing it. On a clean server it works great.

cnaude commented 9 years ago

It's likely just any mod that may be handling chat events. Which of your mods have chat related functions?

Rhodizzle commented 9 years ago

I'm going through them now.

Rhodizzle commented 9 years ago

The only one that appears blatantly chat related was emotes. Removing that didn't fix it. I'll have to wait until i have time to do it one by one, meh.

cnaude commented 9 years ago

Did build 18 print out an debug messages like "[onServerChat]" in the logs? It should print that as soon as it catches a chat event.

Rhodizzle commented 9 years ago

There was nothing. It was triggering on inbound events from IRC and joins/disconnects, but no chat caused any debug logs. I'm working through removing AsieLib and it's dependencies, it was talking about chat in the log.

Rhodizzle commented 9 years ago

Hah! Asielib 0.3.10 conflicts. Once I removed that it started working correctly...

Rhodizzle commented 9 years ago

Relevant: https://github.com/asiekierka/AsieLib/tree/1.7/src/main/java/pl/asie/lib/chat

There is a specific handler in there for EiraIRC. I wonder if you'll need to ask them to build one for Purple or if it's something that you can address on your end...

I'm testing to see if the disable chat tweaks option in AsieLib fixes it...

cnaude commented 9 years ago

Next build should have a fix for this.

Rhodizzle commented 9 years ago

Ok. Setting enableChatTweaks=false in asielib.cfg also resolves it as a workaround.

Rhodizzle commented 9 years ago

Grabbing build 19, will test with enableChatTweaks set to true.

Rhodizzle commented 9 years ago

i'll post back tomorrow :)

cnaude commented 9 years ago

Make sure to also set "ignore-chat-cancel: true" in your config.yml. Build 20 will require that to be true for the workaround to work.

Rhodizzle commented 9 years ago

With AsieLib's chat mods set to true, I've started up with ignore-chat-cancel set to both true and false on build 20 and it doesn't pass chat. Disabling AsieLib's chat mods is still the only way to get it to work. Did I misunderstand what to expect in build 20?

cnaude commented 9 years ago

Now that I know what mod is causing the problem I'll test it on my side and get this worked out. do you happen to have the debug output from the startup?

Rhodizzle commented 9 years ago

I'll see what I can grab later.

On Thu, May 14, 2015 at 8:12 AM, Chris notifications@github.com wrote:

Now that I know what mod is causing the problem I'll test it on my side and get this worked out. do you happen to have the debug output from the startup?

— Reply to this email directly or view it on GitHub https://github.com/cnaude/PurpleIRC-forge/issues/1#issuecomment-102048050 .

cnaude commented 9 years ago

I tested the latest build with AsiesLib and it works correctly. When you have a moment please load build 21 and enable debug mode. Also double check that ignore-chat-cancel is set to true in your config.yml.

Rhodizzle commented 9 years ago

Nice, now it's working!

On Thu, May 14, 2015 at 7:35 PM, Chris notifications@github.com wrote:

I tested the latest build with AsiesLib and it works correctly. When you have a moment please load build 21 and enable debug mode. Also double check that ignore-chat-cancel is set to true in your config.yml.

— Reply to this email directly or view it on GitHub https://github.com/cnaude/PurpleIRC-forge/issues/1#issuecomment-102217567 .

Rhodizzle commented 9 years ago

Solved in build 21: http://h.cnaude.org:8081/job/PurpleIRC-forge/21/