cnaude / PurpleIRC

Minecraft Bukkit plugin that provides an IRC bridge. This repo has been archived. Please see https://github.com/cnaude/PurpleIRC-spigot for the latest and greatest PurpleIRC code for Bukkit servers (Spigot, Paper etc...)
20 stars 9 forks source link

Blank message being sent to channel with VanishNoPacket #42

Closed ProfX66 closed 10 years ago

ProfX66 commented 10 years ago

We have noticed that when a player that has vanish permissions leaves the server, the IRC bot will print a blank message to the channel. There are no errors in console.

PurpleIRC Version: 2.0.6 VanishNoPacket Version: 3.18.5

cnaude commented 10 years ago

Please enable debug mode and paste the output from when a vanished player leaves. You can turn it off and on easily with "/irc debug t" and "/urc debug f".

ProfX66 commented 10 years ago

Here is the console print, I joined vanished and then immediately quit while still vanished. Looks like it thinks I'm not vanished. It also gives me the same exact console print and blank message if I leave unvanished.

10:00:37 [INFO] profx[maskedip] logged in with entity id 647696 at ([main] -58.91779699120472, 70.0, 221.46218067313325) 10:00:37 [INFO] [VanishNoPacket] profx disappeared. 10:00:37 [INFO] [PurpleIRC] [DEBUG] Checking if player profx is vanished. 10:00:37 [INFO] [PurpleIRC] [DEBUG] Player profx has vanished metadata. 10:00:37 [INFO] [PurpleIRC] [DEBUG] Player profx is vanished. 10:00:37 [INFO] [PurpleIRC] [DEBUG] Not sending join message to IRC for player profx due to being vanished. 10:00:50 [INFO] profx lost connection: disconnect.quitting 10:00:50 [INFO] [PurpleIRC] [DEBUG] Checking if player profx is vanished. 10:00:50 [INFO] [PurpleIRC] [DEBUG] Player profx has vanished metadata. 10:00:50 [INFO] [PurpleIRC] [DEBUG] Player profx is NOT vanished. 10:00:50 [INFO] [PurpleIRC] [DEBUG] Tokenizing profx_(O: true) 10:00:50 [INFO] [PurpleIRC] [DEBUG] getWorldAlias: worldName => main 10:00:50 [INFO] [PurpleIRC] [DEBUG] getWorldAlias: alias => Overworld 10:00:50 [INFO] [PurpleIRC] [DEBUG] getWorldColor: worldName => main 10:00:50 [INFO] [PurpleIRC] [DEBUG] getWorldColor: color => §f 10:00:50 [INFO] [PurpleIRC] [DEBUG] [P]Raw message: §6%MESSAGE% 10:00:50 [INFO] [PurpleIRC] [DEBUG] Entering aysncIRCMessage 10:00:50 [INFO] [PurpleIRC] [DEBUG] About to send IRC message to #General 10:00:50 [INFO] [PurpleIRC] [DEBUG] Message sent to #General

cnaude commented 10 years ago

What does your bot yml look like?

cnaude commented 10 years ago

Make sure "hide-join-when-vanished": true and "hide-quit-when-vanished: true" are set.

ProfX66 commented 10 years ago

Both are set to true, here is my bot yml, I omitted the IRC connection information and the rest of the commands that are listed.

raw-message-on-connect: false raw-message: auth name pass relay-private-chat: false command-notify: enabled: false mode: msg recipients:

- '*'
autojoin: true
modes: ''
password: ''
topic: New topic
topic-protect: false
enabled-messages:
- console-chat
- game-action
- game-chat
- game-death
- game-kick
- game-join
- game-quit
- irc-action
- irc-chat
- irc-pchat
- irc-kick
- irc-topic
- irc-nickchange
hero-channel: admin
ops:
- '*!*ProfX@maskedip'
- '*!*Frobobits@maskedip'
muted:
- KuShy
ignore-irc-chat: false
custom-tab-ignore-list:
- AwesomeBot
hide-join-when-vanished: true
hide-quit-when-vanished: true
commands:
  chat:
    modes: '*'
    private: 'false'
    ctcp: 'false'
    game_command: '@chat'
    private_listen: 'true'
    channel_listen: 'true'
cnaude commented 10 years ago

Please try this version: https://dl.dropboxusercontent.com/u/30679730/dist/PurpleIRC.jar

ProfX66 commented 10 years ago

That build fixed it. Works very well now. Thank you!

cnaude commented 10 years ago

Fixed in 2.0.7.