search

cnaude / PurpleIRC

Minecraft Bukkit plugin that provides an IRC bridge. This repo has been archived. Please see https://github.com/cnaude/PurpleIRC-spigot for the latest and greatest PurpleIRC code for Bukkit servers (Spigot, Paper etc...)
20 stars 9 forks source link

Won't work with YAPP #5

Closed ghost closed 11 years ago

ghost commented 11 years ago

Hey, using YAPP as a permissions plugin causes some issues with this plugin. Was just testing and thought I should mention.

YAPP is a permissions plugin that supports Vault, however Vault does not hook into it, YAPP hooks into Vault so it seems there has to be a soft dep on YAPP in the plugin.yml. However, when I add that I still have issues.

Bukkit page: http://dev.bukkit.org/server-mods/yapp

Code: http://code.google.com/p/nisovin-minecraft-bukkit-plugins/source/browse/trunk/YAPP/

Vault code: http://code.google.com/p/nisovin-minecraft-bukkit-plugins/source/browse/trunk/YAPP/#YAPP%2Fsrc%2Fcom%2Fnisovin%2Fyapp%2Fvault

Here is one of the errors:

2013-06-02 18:22:33 [SEVERE] Could not pass event PlayerJoinEvent to PurpleIRC v1.3.3
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
        at org.bukkit.plugin.TimedRegisteredListener.callEvent(TimedRegisteredListener.java:26)
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:479)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:464)
        at net.minecraft.server.v1_5_R3.PlayerList.c(PlayerList.java:204)
        at net.minecraft.server.v1_5_R3.PlayerList.a(PlayerList.java:100)
        at net.minecraft.server.v1_5_R3.PendingConnection.d(PendingConnection.java:134)
        at net.minecraft.server.v1_5_R3.PendingConnection.c(PendingConnection.java:49)
        at org.spigotmc.MultiplexingServerConnection.b(MultiplexingServerConnection.java:77)
        at net.minecraft.server.v1_5_R3.MinecraftServer.r(MinecraftServer.java:583)
        at net.minecraft.server.v1_5_R3.DedicatedServer.r(DedicatedServer.java:227)
        at net.minecraft.server.v1_5_R3.MinecraftServer.q(MinecraftServer.java:472)
        at net.minecraft.server.v1_5_R3.MinecraftServer.run(MinecraftServer.java:404)
        at net.minecraft.server.v1_5_R3.ThreadServerApplication.run(SourceFile:573)
Caused by: java.lang.NullPointerException
        at org.bukkit.ChatColor.translateAlternateColorCodes(ChatColor.java:203)
        at com.cnaude.purpleirc.PurpleIRC.getGroupPrefix(PurpleIRC.java:317)
        at com.cnaude.purpleirc.Utilities.ChatTokenizer.gameChatToIRCTokenizer(ChatTokenizer.java:94)
        at com.cnaude.purpleirc.PurpleBot.gameJoin(PurpleBot.java:521)
        at com.cnaude.purpleirc.GameListeners.GameListeners.onPlayerJoinEvent(GameListeners.java:61)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:601)
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
        ... 14 more
cnaude commented 11 years ago

Please try this version: https://dl.dropboxusercontent.com/u/30679730/dist/PurpleIRC.jar

ghost commented 11 years ago

Thanks =)

That fixes the error but chat from the server to IRC doesn't work. I don't get any errors though.

It does work fine with PurpleIRC 1.0.0 though.

ghost commented 11 years ago

Sorry, spoke too soon. I got an error when I quit.

Also if it matters this is on spigot build 866 and I am also testing using TitanChat. Though I could test with other things if necessary I don't know if it matters or not.

2013-06-02 21:33:36 [SEVERE] Could not pass event PlayerQuitEvent to PurpleIRC v1.3.5-TEST1
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
        at org.bukkit.plugin.TimedRegisteredListener.callEvent(TimedRegisteredListener.java:26)
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:479)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:464)
        at net.minecraft.server.v1_5_R3.PlayerList.disconnect(PlayerList.java:256)
        at net.minecraft.server.v1_5_R3.PlayerConnection.a(PlayerConnection.java:691)
        at org.spigotmc.netty.NettyNetworkManager.b(NettyNetworkManager.java:198)
        at net.minecraft.server.v1_5_R3.PlayerConnection.d(PlayerConnection.java:109)
        at net.minecraft.server.v1_5_R3.ServerConnection.b(SourceFile:35)
        at org.spigotmc.MultiplexingServerConnection.b(MultiplexingServerConnection.java:72)
        at net.minecraft.server.v1_5_R3.MinecraftServer.r(MinecraftServer.java:583)
        at net.minecraft.server.v1_5_R3.DedicatedServer.r(DedicatedServer.java:227)
        at net.minecraft.server.v1_5_R3.MinecraftServer.q(MinecraftServer.java:472)
        at net.minecraft.server.v1_5_R3.MinecraftServer.run(MinecraftServer.java:404)
        at net.minecraft.server.v1_5_R3.ThreadServerApplication.run(SourceFile:573)
Caused by: java.lang.NullPointerException
        at java.lang.String.replace(String.java:2180)
        at com.cnaude.purpleirc.Utilities.ChatTokenizer.gameChatToIRCTokenizer(ChatTokenizer.java:102)
        at com.cnaude.purpleirc.PurpleBot.gameQuit(PurpleBot.java:536)
        at com.cnaude.purpleirc.GameListeners.GameListeners.onPlayerQuitEvent(GameListeners.java:52)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:601)
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
        ... 15 more
cnaude commented 11 years ago

Please test it without TitanChat. Spigot should be okay.

ghost commented 11 years ago

Yes it is TitanChat's fault. Thanks =)

cnaude commented 11 years ago

It'll take some time to figure what TitanChat is doing. I was able to verify on my test box that TitanChat is not playing nice.

ghost commented 11 years ago

I know it has a github https://github.com/TitanDevelopment/TitanChat and jenkins here: http://ci.whitejack.co/job/TitanChat/

The dev NodinChan has been very friendly and helpful in the past and has fixed bugs I have found very quickly when chatting to them in the #TitanDev channel on the EsperNet IRC server.

ghost commented 11 years ago

Also, to be clear, I believe the error when quitting still happens to me without TitanChat, but the issue of chat from server to IRC was caused by TitanChat. I thought I mentioned that but I don't see it anywhere.

cnaude commented 11 years ago

I had a look at the TitanChat code. I think i'll set this up to be very similar to HeroChat.

cnaude commented 11 years ago

I have built a new version that supports TitanChat. https://dl.dropboxusercontent.com/u/30679730/dist/PurpleIRC.jar Please test it and let me know if it works for you.

ghost commented 11 years ago

Thanks! I will give it a shot and see how it goes today and let you know.

ghost commented 11 years ago

I can't seem to get it to work properly.

cnaude commented 11 years ago

What does your bot yml look like? On startup does PurpleIRC detect TitanChat?

ghost commented 11 years ago

Aha, that gave me a clue. I had to add - titan-chat to the bot file and it works! Woohoo!

Thank you =) Do you need me to test anything else?

cnaude commented 11 years ago

Glad it's working for you. If you run into issues with it let me know.