cnblogs / EnyimMemcachedCore

.NET Memcached client. Available on https://www.nuget.org/packages/EnyimMemcachedCore
Apache License 2.0
162 stars 45 forks source link

Replace Microsoft.AspNetCore.Http.Abstractions with Microsoft.AspNetCore.App #172

Closed hazzik closed 2 years ago

hazzik commented 2 years ago

Last version of Microsoft.AspNetCore.Http.Abstractions was released as part of .NET Core 2.2 and have been replaced by Microsoft.AspNetCore.App (See https://github.com/dotnet/aspnetcore/issues/3756 for more details).

Subsequently .NET Core 2.2 has run out of support almost three years ago.

Microsoft.AspNetCore.Http.Abstractions has a dependency on System.Text.Encodings.Web@4.5.0 that have a critical security vulnerability.

This change will fix vulnerability issue for anyone who is using .NET 6.

hazzik commented 2 years ago

Potentially there might be better solution - to split EnyimMemcachedApplicationBuilderExtensions into own package, because it is the only place where Microsoft.AspNetCore.Http.Abstractions is used.

hazzik commented 2 years ago

Anyone?

pulp-fiction-john-travolta

cnblogs-dudu commented 2 years ago

Sorry for the delayed response.

hazzik commented 2 years ago

Thanks

cnblogs-dudu commented 2 years ago

The EnyimMemcachedCore 2.5.5 has been released for this PR.

recepakyuz commented 1 year ago

hi @cnblogs-dudu @hazzik , we have got a problem with this pr. If we you use only .net runtime. application doesnt up. Because .net 6 applications have to run over aspnet.core runtime. We run our project on docker. And this projects use mcr.microsoft.com/dotnet/runtime:6.0 default image. We need to rollback this pr.

cnblogs-dudu commented 1 year ago

@recepakyuz rollbacked in EnyimMemcachedCore 2.6.5.