search

cncf-tags / container-device-interface

Apache License 2.0
200 stars 37 forks source link

Add CDI support to ctr command line #142

Closed elezar closed 2 days ago

elezar commented 1 year ago

Support for specifying CDI devices should be added to the ctr command line. This should mirror what is done for podman and docker.

Note that ctr supports a --gpu flag for requesting NVIDIA GPUs and this feature should be considered a replacement for this.

elezar commented 1 year ago

/cc @bart0sh

bart0sh commented 1 year ago

FWIW here are previous similar PRs:

elezar commented 1 year ago

I created https://github.com/containerd/containerd/pull/8525 to add support using the existing CDI infrastructure instead.

bart0sh commented 1 year ago

I created containerd/containerd#8525 to add support using the existing CDI infrastructure instead.

Can you explain where CDI injection happens? Is it only on a client(ctr) side, or it also involves containerd somehow?

elezar commented 4 months ago

@bart0sh this only happens on the client (ctr) side.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed.

github-actions[bot] commented 2 days ago

This issue was automatically closed due to inactivity.