search

cncf-tags / container-device-interface

Apache License 2.0
216 stars 39 forks source link

pkg/cdi: drop unused return value from Configure methods #189

Closed marquiz closed 5 months ago

marquiz commented 10 months ago

NOTE: This change changes the exported API of "pkg/cdi" package as the prototype of Configure() method of Cache and Registry types changes.

A follow-up on top of #188

elezar commented 9 months ago

We discussed this change in the COD working group meeting and would suggest that we do not merge it. See https://docs.google.com/document/d/1gUgAMEThkRt4RJ7pA7ZbPPmIOX2Vb7fwH025MjfcTYU/edit#bookmark=id.khpjizwm6m54

We already have clients that use this function (Containerd, Cri-o) and this would require explicit code changes on their end. Furthermore, it is reasonable to assume that we could require Options that return errors at some point.

github-actions[bot] commented 6 months ago

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed.

github-actions[bot] commented 5 months ago

This pull request was automatically closed due to inactivity.