search

cncf-tags / container-device-interface

Apache License 2.0
190 stars 36 forks source link

pkg,schema,internal: eliminate multierror. #196

Closed klihub closed 4 months ago

klihub commented 4 months ago

Migrate from our internal multierror implementation to using error slices and stock errors.Join().

klihub commented 4 months ago

I think we need to bump our go version to at least 1.19.

Yeah, I figured too.

elezar commented 4 months ago

Are our clients using go >= 1.21 to build their applications?

For completeness, I recently did something similar in one of our projects to enable errors.Join in go1.17: https://github.com/NVIDIA/nvidia-container-toolkit/pull/337

klihub commented 4 months ago

The use of errors.Join can clean this up even further since it's never required to store a slice of errors.

If you don't care about how the topology of the final set of stored errors look like, but (for some reason) I prefer to keep errors 'at the same level' in the same slice (of joinErrors) and only 'cascading result of errors' (errors caused by other errors) nested the way it would be if we used the code you suggested. See my other related comment...

elezar commented 4 months ago

The use of errors.Join can clean this up even further since it's never required to store a slice of errors.

If you don't care about how the topology of the final set of stored errors look like, but (for some reason) I prefer to keep errors 'at the same level' in the same slice (of joinErrors) and only 'cascading result of errors' (errors caused by other errors) nested the way it would be if we used the code you suggested. See my other related comment...

OK. That's a fair point. I was not considering this aspect.