search

cncf-tags / container-device-interface

Apache License 2.0
190 stars 36 forks source link

Bump clients to v0.7.1 #199

Open elezar opened 3 months ago

elezar commented 3 months ago

The following clients need to be updated to use https://github.com/cncf-tags/container-device-interface/releases/tag/v0.7.1

Note the deprecated APIs.

kannon92 commented 3 months ago

What is required for CRIO?

elezar commented 2 months ago

@kannon92 we need to bump the dependencies and (optionally) move from the deprecated APIs. The containerd PR should be similar enough to be used as a guideline.

kannon92 commented 2 months ago

I’ll see about doing it next week and I’ll cherry pick it to 1.30.

we are in the process of bumping a lot of dependencies right now with recent podman release.

kannon92 commented 2 months ago

@klihub got to it already.

https://github.com/cri-o/cri-o/pull/7971

kannon92 commented 2 months ago

How important is this for 1.30?

There is a very unlikely chance this will go into k8s 1.30.

CRI-O 1.30 branch aims to be 1on1 with k8s 1.30.

bart0sh commented 2 months ago

@kannon92 I don't think it's important as most of changed functionality makes sense only for runtimes.

kannon92 commented 2 months ago

I did a quick search into kubernetes but didn't see that cdi is a dependency.

elezar commented 2 months ago

Kubernetes doesn't depend on the spec at all. It should only be forwarding the cdi device names as opaque strings. There is some logic around constructing the container annotations (if required) that may be shareable, but I don't believe we pull anything in for that. There were concerns about dependencies at some point and the relevant logic was duplicated instead.

bart0sh commented 2 months ago

It will depend on CDI spec soon. It's in my short term TODO list.

So far there are two places in the k/k code that would benefit from it:

kannon92 commented 2 months ago

@klihub @elezar thank you for your patience on the crio work. We had some long lasting bugs around our CI images. this actually helped get a PR I had sitting for a few months also so it is greatly apprechiated!

You can mark the crio ones as complete. We will fast forward main into release-1.30 as we have not yet kicked off the release for crio 1.30.

klihub commented 2 months ago

@klihub @elezar thank you for your patience on the crio work. We had some long lasting bugs around our CI images. this actually helped get a PR I had sitting for a few months also so it is greatly apprechiated!

Thank for all your help with this, too !