fix: Updates to proposal 1

cncf-tags / green-reviews-tooling

Project Repository for the WG Green Reviews which is part of the CNCF TAG Environmental Sustainability

https://github.com/cncf/tag-env-sustainability/tree/main/working-groups/green-reviews

Apache License 2.0

27 stars 14 forks source link

fix: Updates to proposal 1 #102

Closed rossf7 closed 4 months ago

rossf7 commented 5 months ago

What type of PR is this?

kind/documentation

What this PR does / why we need it:

Update proposal 1 to

Make releases check weekly instead of hourly. As we feel hourly is too often.
Use releases endpoint instead of Atom feed
Use JSON not YAML for projects metadata to avoid need for Go YAML library

Also adds missing link to atom feed.

Which issue(s) this PR fixes:

None

Special notes for your reviewer (optional):

cc @dipankardas011

dipankardas011 commented 5 months ago

@rossf7 as you are adding the atom release here may be we can change the purpose of this pr itself if its okay? and make the necessary changes to accommodate for the jq one WDYT?

rossf7 commented 5 months ago

as you are adding the atom release here may be we can change the purpose of this pr itself if its okay?

@dipankardas011 Yes sure. Done

rossf7 commented 4 months ago

@nikimanoledaki @dipankardas011

Thank you! I'll create an implementation issue for the renaming.

Should the trigger script be running on PRs?

No I think it should only run if there is a change to scripts dir.

Proposed a fix in #109