search

cncf-tags / green-reviews-tooling

Project Repository for the WG Green Reviews which is part of the CNCF TAG Environmental Sustainability
https://github.com/cncf/tag-env-sustainability/tree/main/working-groups/green-reviews
Apache License 2.0
23 stars 14 forks source link

Proposal 1: Trigger and Deploy #88

Closed dipankardas011 closed 4 months ago

dipankardas011 commented 5 months ago

What type of PR is this?

kind/documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #84

Special notes for your reviewer (optional):

cc @rossf7

dipankardas011 commented 4 months ago

@rossf7 should we add the github variable part as well or we should test once we almost got the implementation and then we can optimize the variable thing before finishing the issue?

rossf7 commented 4 months ago

should we add the github variable part as well

@dipankardas011 I added a note about using variables in the Subscribing to Releases section. Is that OK or do you think more detail is needed?

dipankardas011 commented 4 months ago

should we add the github variable part as well

@dipankardas011 I added a note about using variables in the Subscribing to Releases section. Is that OK or do you think more detail is needed?

Yes then it's okay, thanks for adding that

ADiTuri commented 4 months ago

LGTM, I added just a minor comment, great job!

rossf7 commented 4 months ago

First proposal down 🚀

Thank you @dipankardas011 for all your hard work on it and to all the reviewers! 💚