search

cncf-tags / green-reviews-tooling

Project Repository for the WG Green Reviews which is part of the CNCF TAG Environmental Sustainability
https://github.com/cncf/tag-env-sustainability/tree/main/working-groups/green-reviews
Apache License 2.0
23 stars 14 forks source link

Revert changes for dedicated documentation website #94

Closed guidemetothemoon closed 3 months ago

guidemetothemoon commented 4 months ago

What type of PR is this?

kind/documentation

What this PR does / why we need it:

Reverting changes for having a dedicated documentation website. All documentation is located in the docs folder at the root of the repo. Markdown linter fixes and metadata for Hugo pages is preserved for the future place where this content will be available as part of the website.

Which issue(s) this PR fixes:

Related to #89

Special notes for your reviewer (optional):

nikimanoledaki commented 4 months ago

Huh, I should be able to merge this PR (and was able to do so previously) but that's no longer possible. It requires a second approving review from @cncf-tags/tag-env-leads 🤔

Requiring 2 PR reviews would slow down the (already slow) pace of the project 🙈

guidemetothemoon commented 4 months ago

I'm not sure who added the TAG ENV leads as reviewers - it wasn't me at least and I'm not sure if it's really needed for every PR? Maybe this is a consequence of some new governance rule that I'm not aware of...

@leonardpahlke @mkorbi please comment if you know anything about this change. I can't approve my own PR so one of you needs to review it as well.

rossf7 commented 4 months ago

I'm not sure who added the TAG ENV leads as reviewers - it wasn't me at least and I'm not sure if it's really needed for every PR? Maybe this is a consequence of some new governance rule that I'm not aware of...

@guidemetothemoon this is due to the CODEOWNERS rules added in #82 There are a list of known file extensions that Green Reviews leads can approve and * that needs approval from TAG ENV leads.

The problem is reverting includes changes such as .toml that are not in the list. Once this is merged the rules will be correct again.

@leonardpahlke @mkorbi Can one of you review?

If this happens often we might need to look at the CODEOWNERS rules again.

nikimanoledaki commented 4 months ago

Hey @rossf7, thank you for clarifying this! ☺️ What is the benefit of having this distinction? Could we move everything under @cncf-tags/tag-env-wg-green-reviews-leads? 🤔 The more people we can pool reviews+merging from, the faster the pace of the project. :)

AntonioDiTuri commented 3 months ago

Merging as discussed in https://github.com/cncf-tags/green-reviews-tooling/issues/65#issuecomment-2158363106