cncf-tags / green-reviews-tooling

Project Repository for the WG Green Reviews which is part of the CNCF TAG Environmental Sustainability
https://github.com/cncf/tag-env-sustainability/tree/main/working-groups/green-reviews
Apache License 2.0
23 stars 14 forks source link

[ACTION] Implement deploy step of pipeline #99

Closed rossf7 closed 3 months ago

rossf7 commented 4 months ago

Task Description

Implement deploy step of green review pipeline. This is the first step of the pipeline and is followed by the benchmark and report steps.

Design is described in proposal 1. See trigger, deploy and cleanup sections.

https://github.com/cncf-tags/green-reviews-tooling/blob/main/docs/proposals/proposal-001-trigger-and-deploy.md#trigger

Tasks

SFulpius commented 4 months ago

I'm taking this issue.

SFulpius commented 3 months ago

One parameter of the workflow is the version parameter, which is defined as Version of project to be tested in proposal 1. But what does it refers to exactly? To one git tag, to the image tag or something else?

rossf7 commented 3 months ago

One parameter of the workflow is the version parameter, which is defined as Version of project to be tested in proposal 1. But what does it refers to exactly? To one git tag, to the image tag or something else?

@SFulpius Good to clarify this. Its the git tag. For Falco we need it so we pull the correct image tag in the daemonset. e.g. 0.38.0 is the latest release https://github.com/falcosecurity/falco/releases/tag/0.38.0

Something else that should probably be in the proposal and / or here is the implementation language for the workflow.

Our preference is to use bash whenever possible to have less dependencies.

If this isn't possible or a higher level language is a better option then our preference is Go using the stdlib. As our team is most familiar with Go and its widely used within CNCF.

The steps here will mostly be using kubectl but I wanted to mention it and I'll add it to the agenda for next weeks meeting.