Closed eddie-knight closed 7 months ago
/assign @tegioz
@tegioz please take another look, I'm pretty sure I've applied all the requested changes
Thanks @eddie-knight, it looks great 👍
Would you also like to add the cloud-provider-aws
(#1384) and gateway-api
(#1381) subprojects to this PR? They kind of have to fix the same details and we could leave them all ready now 🙂
I went ahead and pulled in the commits from the other PRs and rebased them into a single history here
Should probably add both k8s.io/minikube
and sigs.k8s.io/kind
, since they share some of the container code?
https://github.com/kubernetes/minikube
https://github.com/kubernetes-sigs/kind
The minikube project is older than the creation of the kubernetes-sigs organisation, so it still lives in kubernetes.
ref: https://docs.google.com/spreadsheets/d/1Y9hNtp6NaEtp_B0ccwMI06YBdENz3guh93MlPHwdPXM/edit#gid=0