search

cncf / cncf.io

☁️♮🏛🚧 The CNCF.io WordPress website
https://cncf.io
MIT License
82 stars 37 forks source link

Various fixes (July) #568

Closed thetwopct closed 2 years ago

thetwopct commented 2 years ago
cjyabraham commented 2 years ago
thetwopct commented 2 years ago
  • I'm not sure what you did with the Who We Are gallery but on mobile it no longer has consistent spacing between the stacked images. I'm not sure, however, if that's just a problem with this database instance. Does this require a change once we deploy?

Hmm I forgot to set the PR up with the proper class for styling - can you add has-masonry-layout class to the container column block and see if that fixes the issues? If not I will have another look, but I did also work on standard gallery spacing after I worked on this, so perhaps that messed up the masonry style.

  • Safari drop shadow disappearing on hover appears fixed for the news tiles on the homepage but not for other tiles like those on the Staff page or online programs page. Can you check through all tiles?

OK, but, when I did this it did raise some questions about drop shadows - like why on the home page has only News now got a shadow? Seems inconsistent and wasn't how it used to be, so I wonder if they should even be there? FYI, it seems the filter:drop-shadow() CSS + transform causes this, but using the older box-shadow() css is the fix for this.

cjyabraham commented 2 years ago
  • I'm not sure what you did with the Who We Are gallery but on mobile it no longer has consistent spacing between the stacked images. I'm not sure, however, if that's just a problem with this database instance. Does this require a change once we deploy?

Hmm I forgot to set the PR up with the proper class for styling - can you add has-masonry-layout class to the container column block and see if that fixes the issues? If not I will have another look, but I did also work on standard gallery spacing after I worked on this, so perhaps that messed up the masonry style.

I've tried this but it doesn't seem to have had an effect. I'm actually not sure what initial problem you were trying to solve? I thought things were fine as they are on the live site.

  • Safari drop shadow disappearing on hover appears fixed for the news tiles on the homepage but not for other tiles like those on the Staff page or online programs page. Can you check through all tiles?

OK, but, when I did this it did raise some questions about drop shadows - like why on the home page has only News now got a shadow? Seems inconsistent and wasn't how it used to be, so I wonder if they should even be there? FYI, it seems the filter:drop-shadow() CSS + transform causes this, but using the older box-shadow() css is the fix for this.

True, the homepage has kind of its own style. This aside, drop shadows on standard tiles are mostly consistent throughout the site and I think they look decent.

thetwopct commented 2 years ago

I've tried this but it doesn't seem to have had an effect. I'm actually not sure what initial problem you were trying to solve? I thought things were fine as they are on the live site.

has-masonry-layout was applied to the parent column not the parent columns - have updated it and it now looks fine mobile and desktop. There was nothing wrong with this layout, except its config was messing with the generic gallery, so I moved its styling to the has-masonry-layout class and then the other galleries work again.

thetwopct commented 2 years ago