Closed cjyabraham closed 1 year ago
@thetwopct I think this is ready for you now. You'll need to insert the HTML needed into the show_event_for_menu
and show_event_banner
functions. Code sniffs aren't passing right now as it's just my test HTML that will be removed anyway.
@cjyabraham As the slider banner design arrows inside/outside the container has not been finalised yet and likely will not be until next week (as Gareth is on holiday), and with ArgoCon over tomorrow, I have made the changes we discussed but only implemented a singular banner display on the home page so we can update the banner for Kubecon.
We can add the text above the banner and the slider as a separate PR/commit later once the design is finalised.
Note, on production the home page will need to be updated with the new shortcode - event_banner
, and the spacer underneath the section should be deleted as that is now part of its conditional display
Sounds good. I've asked G for the updated Detroit assets at the dimensions I calculate we'll need for retina screens (LMK if you disagree with the dimensions). The mobile version of the banner you have on this dev site is quite blurry so didn't want to launch with that. As soon as we get them we can merge this PR and launch with the Detroit banner.
Also can you round the corners here?
Issue #570
Dev instance
Signed-off-by: cjyabraham cjyabraham@gmail.com