cncf / cncf.io

☁️♮🏛🚧 The CNCF.io WordPress website
https://cncf.io
MIT License
84 stars 38 forks source link

Make GDPR banner WCAG-compliant #655

Closed cjyabraham closed 1 year ago

cjyabraham commented 1 year ago

PR instance

Signed-off-by: cjyabraham cjyabraham@gmail.com

thetwopct commented 1 year ago

@cjyabraham Looks fine although I thought it was a requirement to distinguish links from text? https://dequeuniversity.com/rules/axe/4.4/link-in-text-block If so, perhaps reversing your styling would fix this - i.e. underline the links always and remove the underline on hover. image In this screenshot, a link making it clear the last words were a link would be good I think.

FYI pushed some housekeeping to this branch (found some issues while setting up new Mac)

cjyabraham commented 1 year ago

Ok, got the underline reversed then. Make sense.