cncf / cncf.io

☁️♮🏛🚧 The CNCF.io WordPress website
https://cncf.io
MIT License
80 stars 37 forks source link

Tier 3 blocks p1 #661

Closed thetwopct closed 1 year ago

thetwopct commented 1 year ago

This PR includes some updates required to immediately launch the Security Slam Tier 3 report.

Can you please check for any breaking changes and for any display issues with the new blocks (I've used them in this report - note: the content should not be reviewed). If approved, I can handle merging etc.

cjyabraham commented 1 year ago
  1. The "PUBLISHED" line here and here are different sizes. Can we pick one and be consistent? The large version looks too big on mobile.
  2. Did you consider making the eye brow bread crumbs, title, and published line a single block that can be put at the top of a post without needing all the spacers? Wouldn't you always want all three together like that if you have the bread crumbs?
  3. Does it make sense to tack on Share links to the bottom of the report page or template?
  4. It looks like the spacing has increased below existing quote, before the citation block. Compare the quote on this case study vs the live one.
  5. When I go to edit the report, I see "Default Template" set for the report template. On clicking it, I see it is actually set to "No Page Title". I'm guessing that is a bug in WP?
  6. I tried setting the text color on a quote block (see the last quote in the report), however, it doesn't show up on the front-end.
thetwopct commented 1 year ago

Thanks Chris.

  1. Updated, it just need small text size applied to the block
  2. Yes, but the breadcrumb is also needed for another report header style (PJR). So I was going to establish a Pattern template that could be inserted (Imagine there will be several).
  3. They will be/are a block, and part of a more complex hero section
  4. Yes I felt it was better to have equal spacing above and below. It was uneven and depending on where the quote was it was very obvious.
  5. Yes a WP bug, been like that for a while. I believe its this issue, but doesn't seem to be a priority for core committers https://github.com/WordPress/gutenberg/issues/47428
  6. Thanks, I'll fix that
cjyabraham commented 1 year ago

I disagree with 4. I think it just looks too far away from the quote itself to the point where people might think they're seeing a heading for a subsequent section rather than a citation for the preceding quote.

thetwopct commented 1 year ago

Ah. I was confused and looking at the wrong thing. Yes I can see the issue now. It's weird, looks like the line-height of the quote was affecting the cite, not sure why it would start now as other changes in the css file for this shouldn't have affected it. Anyway, I should have fixed it now by adding line-height specifically for the cite.