cncf / cncf.io

☁️♮🏛🚧 The CNCF.io WordPress website
https://cncf.io
MIT License
84 stars 38 forks source link

Launch CNSC Transparency Report #671

Closed thetwopct closed 1 year ago

thetwopct commented 1 year ago

Workflow

PR

IMAGES

LINKS

TEXT

CONFORMANCE

GO LIVE

thetwopct commented 1 year ago

PR

Changes: (FYI @bpipalia-aragona)

h1, h2, h3 { color: $cnsc-na-23-blue-900; // text-transform: uppercase; }

To Discuss:

  1. There was a change of how the CSS is loaded - prefetch to preload. We used prefetch to stop FOUC. Not sure if it matters on this small report, but interested to hear your thoughts as to why the change. Screenshot-2023-03-07 --13 57 21@2x
thetwopct commented 1 year ago

Added more spacing to Hero area based on feedback from @GarethAcidWorks

Also had to re-export all photos in gallery at 3x not 2x as quality was low on HQ monitors

Removed " from text in quotes

alanglois-aragona commented 1 year ago

@thetwopct thanks for all your feedback. Looks like we still have work to do on our end.

I do want to touch on a few points specifically:

  1. We are used to exporting images @ 2x. We find that's a good compromise between quality and file size, but we will start exporting @ 3x as you mentioned. The JPG vs PNG for the banner background was a mistake and I didn't catch it in my internal review.
  2. For things like spacing, SVGs, and ALT text we use what's provided to us. If we don't have something we look at other reports to see what was done in the past. During last weeks meeting with Kristi it was confirmed that we will follow the design to the pixel and all images and their alt text would be provided to us.
  3. As for changing the CSS from prefetch to preload, we did that because we ran the page through Lighthouse and it suggested we do that. However, if prefetch is the preferred method we'll keep it like that going forward.
thetwopct commented 1 year ago

@alanglois-aragona

  1. No problems. I think I put in my first email use 3x and not to worry about sizes of the file as we have ShortPixel to handle downsizing and optimising and srcset to handle delivery.
  2. Sure, the spacing is not always bang on due to the complexity of moving whole sections of figma just to align something, so some common sense needed upon implementation. I didn't really see any issues here anyway. "Design to the pixel" is great, but in reality, we need to apply common sense web checks i.e. accessibility, colours, consistency, performance. As these reports get larger (these last two have been small) these things becoming increasingly important.
  3. OK. We run every report through Lighthouse / PageSpeedInsights and I've never seen that feedback. But we get a warning in console when using preload 🤷

I just pushed a small change requested by @GarethAcidWorks and I'm gonna merge this in to production

thetwopct commented 1 year ago

The report is merged, public preview link while in draft:

https://www.cncf.io/?p=84436&post_type=lf_report&preview=1&_ppp=8f51f2c068

Will track release/publishing in workflow.