search

cncf / cncf.io

☁️♮🏛🚧 The CNCF.io WordPress website
https://cncf.io
MIT License
84 stars 38 forks source link

KCCNA 22 Report: Downloading sponsor logos to local reports folder #683

Closed alanglois-aragona closed 1 year ago

alanglois-aragona commented 1 year ago

Work for #680 Closes #680

thetwopct commented 1 year ago

Thanks @alanglois-aragona

1) Seems to be two broken images:

Screenshot-2023-03-14 --11 55 39@2x

This was caused by filename Likethis.svg and then embedding likethis.svg - you could renamed all filenames to lowercase in future to avoid that perhaps (possibly prefacing each one with "logo-" so easier to find and locate each one in the images directory).

2) I removed the data feather attributes copied from LFE site as they are not needed here. That was my mistake I guess from when the report was originally made (please look out for un-needed tracking stuff in future! Thanks).

Also upgraded embedded video to webP HQ images from SD (this is not always available when first uploading the video on YouTube, so needs to be updated later)

Also added a reference to the original ticket to the PR (it wasn't included in your commit message either). Please try to link work to issues.