cncf / cncf.io

☁️♮🏛🚧 The CNCF.io WordPress website
https://cncf.io
MIT License
80 stars 37 forks source link

Phippy footer improvements, Phippy page improvements #709

Closed thetwopct closed 1 year ago

thetwopct commented 1 year ago

678 Implement new Phippy footer, move it to settings page for quicker updating and srcset

542 Phippy Page design v2

710 Fix no margin class on images?

https://pr-709-cncfci.pantheonsite.io/ (Footer) https://pr-709-cncfci.pantheonsite.io/phippy/ (Phippy page)

See Site Settings -> Phippy for global Phippy settings

Actions:

thetwopct commented 1 year ago

@cjyabraham I've already done it (see commit history) and GitHub is saying no conflicts? I'm going to merge it in now.

Screenshot-2023-04-16 --21 52 09@2x
cjyabraham commented 1 year ago

At that time I wrote my comment GitHub said there were conflicts that would need resolving before merging and the merge button was disabled 🤷‍♂️