cncf / cncf.io

☁️♮🏛🚧 The CNCF.io WordPress website
https://cncf.io
MIT License
80 stars 37 forks source link

Osano Cookie Banner low-contrast issue on mobile #753

Closed thetwopct closed 12 months ago

thetwopct commented 1 year ago

Lighthouse is flagging a link and text in the cookie banner as having poor contrast on mobile devices. WebAims checker says the combination passes (as does AXE).

Should we ignore this warning from Google?

This version of the report shows a screenshot:

Screenshot-2023-06-30 --22 07 58

If we wanted to try and solve:

cjyabraham commented 1 year ago

It seems like Lighthouse is right in this case and the others missed it. Like you suggest, maybe we just keep font sizes the same as on desktop, which passes?

cjyabraham commented 12 months ago

I don't understand why the body text is flagged. Black on blue should have a contrast ratio of 17. The pink on blue does need fixing. I can up the size of the text to 19px which is the minimum I think.

cjyabraham commented 12 months ago

This is deployed and appears to have moved our Accessibility score back to 100.