thetwopct
commented
1 year ago The height is the same for any device over 768px. We based the max height of the modal to roughly fit the longest profiles - 800px height. In this example the person has a short-ish profile. With a long profile on iPad, I would say it looks good:
Setting a max height results in all modals opening in the same place on the screen. I can apply "fit-content" to the max-height, but then the profiles jump around the screen depending on the length of the profile - I don't think this looks good.
Solutions:
- Proceed with all the modals loading at different sizes using fit-content. Looks bad IMO.
- Reduce the max height to say 700px instead of 800px - this would make the example above have slightly less white space but should still work, and would reduce the white space a little for your example. Doesn't really solve the issue though. Reducing to 600px clips off too many profiles.
- Setup differing modal ambassadors height and a staff height - staff typically have shorter profiles (would need to double check on this)
Overall, I would see this as an edge case and as majority of cases it works, I'd suggest this to be a Won't Fix.
cjyabraham
from iPad 10 with Safari