cncf / cncf.io

☁️♮🏛🚧 The CNCF.io WordPress website
https://cncf.io
MIT License
84 stars 38 forks source link

Update: Twitter's logo has been changed to X #769 #771

Closed parmishh closed 11 months ago

parmishh commented 1 year ago

Twitter's logo has been changed to X #769

Instance: https://pr-771-cncfci.pantheonsite.io

cjyabraham commented 1 year ago

There are other twitter logos on the site, such as on these pages:

Would you like to update those as well?

@thetwopct are there any others that would need changing?

parmishh commented 1 year ago

@cjyabraham Sure I would love to help with other sites as well, do you want me to make a issue on these sites to proceed?

cjyabraham commented 1 year ago

It's the same site, just different instances of the logo

parmishh commented 1 year ago

@cjyabraham sure I will make a PR for them as well

cjyabraham commented 1 year ago

You can just include the changes in this same PR that way we can review and deploy them all at once.

thetwopct commented 1 year ago

@thetwopct are there any others that would need changing?

The reports use a different logo but there’s a few different versions.

We need to be wary of the way the logo is used in the various reports we have, many reports apply colors to the social logos. Do we backdate the change to old reports?

Also, it’s not just the logo that’s been/being changed, it’s also the name (Twitter app on App Store is now called X). So alt and title text should also update.

Personally I would not do this change just yet, branding at Twitter/X is in flux, there are no official brand assets or guidelines for X. The x.com domain is not the main domain. I don’t think users will suddenly be confused by seeing a Twitter icon and not knowing where it goes.

cjyabraham commented 1 year ago

Agreed. @parmishh you're welcome to finish off this PR with the changes mentioned above but we may hold off on merging for a while until the new Twitter brand becomes stable and more widely accepted.

parmishh commented 1 year ago

@thetwopct I was also thinking the same we should wait till official brand assets are released. @cjyabraham yes I will finish off this PR with mentioned changes in a while

malaviya-parth commented 1 year ago

about/join Here too in meet the team section

thetwopct commented 11 months ago

Updated/checked use of logo in:

As noted, some of the recent reports use the social share component, so they have automatically updated. Older reports use a different logo that still exists in the images/reports folder, and that should stay there (for now at least).

Rebased on latest and ready to merge from my perspective @cjyabraham