search

cncf / cncf.io

☁️♮🏛🚧 The CNCF.io WordPress website
https://cncf.io
MIT License
80 stars 37 forks source link

Project Journey updates #800

Closed thetwopct closed 8 months ago

thetwopct commented 8 months ago

Deployment Fixes

Will need to check this PR thoroughly - https://pr-800-cncfci.pantheonsite.io

(Need to make sure we squash this PR on merge!)

cjyabraham commented 8 months ago

When I insert a "PJF Section Header" pattern in a page I get a block that says "The block contains unexpected or invalid content": Screenshot 2023-10-19 at 8 35 58 AM

cjyabraham commented 8 months ago

Did you intentionally increase the line-height on the quote block? Looking at the one on the Who We Are page, it is now 43px where before it was 38px.

Also the letter-spacing on the citation is smaller. It's now 0.44px and used to be 0.72px.

cjyabraham commented 8 months ago

The gap has increased between the text and image in the "Program benefits" box on cert pages. Not necessarily a problem, just thought I'd call it out.

cjyabraham commented 8 months ago

lando sniff returns ERROR: You must supply at least one file or directory to process. when I run it locally. Any ideas where this file/dir needs to be provided?

thetwopct commented 8 months ago

Did you intentionally increase the line-height on the quote block? Looking at the one on the Who We Are page, it is now 43px where before it was 38px.

Also the letter-spacing on the citation is smaller. It's now 0.44px and used to be 0.72px.

I don't believe I added or changed any values. These were the values in the CSS and I just properly applied them to the block. Are the values you're not happy with coming from our styles or the default styles?

thetwopct commented 8 months ago

The gap has increased between the text and image in the "Program benefits" box on cert pages. Not necessarily a problem, just thought I'd call it out.

Sorry forgot to mention in notes I added 50px gap to media text block the gap was 24px and that felt too small. Mobile gap was 0px which didn't feel right either.

thetwopct commented 8 months ago

lando sniff returns ERROR: You must supply at least one file or directory to process. when I run it locally. Any ideas where this file/dir needs to be provided?

It's specified in the phpcs.xml.

Maybe rebuild? Lando rebuild -y (non destructive)

cjyabraham commented 8 months ago

lando sniff returns ERROR: You must supply at least one file or directory to process. when I run it locally. Any ideas where this file/dir needs to be provided?

It's specified in the phpcs.xml.

Maybe rebuild? Lando rebuild -y (non destructive)

I started a completely fresh install to test this out.

cjyabraham commented 8 months ago

Did you intentionally increase the line-height on the quote block? Looking at the one on the Who We Are page, it is now 43px where before it was 38px. Also the letter-spacing on the citation is smaller. It's now 0.44px and used to be 0.72px.

I don't believe I added or changed any values. These were the values in the CSS and I just properly applied them to the block. Are the values you're not happy with coming from our styles or the default styles?

Looks like they're coming from our styles. You can compare the quote on this case study vs the one on the live site. I feel the line-height is fine either way, however, I think I prefer the wider letter-spacing from the live site.

thetwopct commented 8 months ago

lando sniff returns ERROR: You must supply at least one file or directory to process. when I run it locally. Any ideas where this file/dir needs to be provided?

It's specified in the phpcs.xml.

Maybe rebuild? Lando rebuild -y (non destructive)

I started a completely fresh install to test this out.

Did you update Lando.yml instructions? PHPCS should pick up the file by default.

thetwopct commented 8 months ago