Open thetwopct opened 2 weeks ago
I think whenever we use the hero takeover technique, we should switch the hello bar to not show on the homepage, as we had for the Kubecon takeover.
On my screen this new hero is quite a bit longer than the normal one. The "REGISTER NOW" button is on the fold line. Even if we remove the hello bar, I still think it's a bit long. Could we match the normal hero height?
I'm not sure I love the purple overlay. It may look better in a darker shade but we could get other opinions.
I think whenever we use the hero takeover technique, we should switch the hello bar to not show on the homepage
Sure, we can update any options, I didn't edit them this just came over in the setup of the dev env
Could we match the normal hero height?
This is caused by the height of the CNSC logo - can you inspect element and see if there is a height of it where it still looks good and not too small and if that fixes your issue?
Maybe try these adjustment from what you have?
.takeover-logo {
margin-top: min(36%, 50px);
}
.home-hero__metric_wrapper {
margin-bottom: min(20%, 70px);
}
Also, I tried this for the overlay and think it looks better... not such an overwhelm of purple: #342645bf
I felt the CNSC logo was too close to the top which is why I didn't want to edit that top spacing. But have implemented.
I would like to put forward the hero colour as is. It's a takeover. It needs to look substantially different to the current and your suggestion does not.
Let's keep this open for when we do the takeover for Kubecon NA #831
home-hero-guest
.PR - https://pr-861-cncfci.pantheonsite.io