cncf / devstats.archive

📈CNCF-created tool for analyzing and graphing developer contributions
https://devstats.cncf.io/
Apache License 2.0
445 stars 147 forks source link

[feature request] - adding ingress-nginx as a project to devstats #349

Closed strongjz closed 2 years ago

strongjz commented 2 years ago

We would like to add https://github.com/kubernetes/ingress-nginx to the dashboard so that we as maintainers can discuss and understand who what and where contributions are coming from.

lukaszgryglicki commented 2 years ago

To which project? Kubernetes? We have 120+ projects.

lukaszgryglicki commented 2 years ago

Ping.

strongjz commented 2 years ago

Ingress-nginx is a subproject of Kubernetes, so I am not sure what you are asking here.

To add the ingress-nginx project, do we follow this? https://github.com/cncf/devstats/blob/master/ADDING_NEW_PROJECT.md

lukaszgryglicki commented 2 years ago

OK so you want to add https://github.com/kubernetes/ingress-nginx repo, but to which CNCF project? If kubernetes - then it is already tracked in https://k8s.devstats.cncf.io...

lukaszgryglicki commented 2 years ago

And if You want to add a new project (new DevStats instance) as described in ADDING_NEW_PROJECT.md - we are only adding CNCF projects, not just repos on user's requests cc @caniszczyk ?

strongjz commented 2 years ago

It's fine to add under kubernetes. I don't see ingress-nginx.

lukaszgryglicki commented 2 years ago

OK, I will check when I have some time.

lukaszgryglicki commented 2 years ago

I can see it in database:

gha=# select * from gha_repos where alias like '%ingress-nginx%';
    id    |           name           |  org_id  | org_login  | repo_group  |          alias           | license_key |    license_name    | license_prob |         created_at         |         updated_at         
----------+--------------------------+----------+------------+-------------+--------------------------+-------------+--------------------+--------------+----------------------------+----------------------------
 72891330 | kubernetes/ingress-nginx | 13629408 | kubernetes | SIG Network | kubernetes/ingress-nginx | apache-2.0  | Apache License 2.0 |          100 | 2020-02-13 07:38:59.026721 | 2021-09-06 02:02:00.150865
 72891330 | kubernetes/ingress       | 13629408 | kubernetes | SIG Network | kubernetes/ingress-nginx | apache-2.0  | Apache License 2.0 |          100 | 2020-02-13 07:38:59.026721 | 2021-09-06 02:02:00.213849
(2 rows)

gha=# 

It has two names kubernetes/ingress-nginx and kubernetes/ingress which means repo was renamed. Now on which dashboard you miss that repo? Note that some dashboards only show top N max active repos, not all.

If any dashboard shows "repository groups" it means that "ingress-nginx" will show as a part of "SIG Network" because it is listed in SIG Network repository group definition here: https://github.com/cncf/devstats/blob/master/scripts/kubernetes/repo_groups.sql#L265 and here https://github.com/cncf/devstats/blob/master/scripts/kubernetes/repo_groups.sql#L267, also see Dashboard for repository groups assignments: https://k8s.devstats.cncf.io/d/68/repository-groups?orgId=1&var-repogroups=SIG%20Network.

There are only few dashbaords that show data for "repositories" alone not "repositoriy groups", for example:

To have all dashboards that use "repository groups" distinguish that single repo you would have to split it out from "SIG Network" into its own 1-repository "repo group".

Hope that amnswers your question.

lukaszgryglicki commented 2 years ago

Closing this, please reopen if needed.