cncf / devstats.archive

📈CNCF-created tool for analyzing and graphing developer contributions
https://devstats.cncf.io/
Apache License 2.0
445 stars 147 forks source link

[Bug]CNCF and K8s devstats doesn't show correct affiliation #396

Closed divya-mohan0209 closed 1 year ago

divya-mohan0209 commented 1 year ago

Hello team,

In April 2022, I raised a PR to update my affiliation. This doesn't seem to have been reflected since my contributions seem to be counted against my previous employer. Please could you take a look?

Cheers, Divya

caniszczyk commented 1 year ago

hey @lukaszgryglicki take a look when you have a minute

lukaszgryglicki commented 1 year ago

I will check data in our JSON but also note that you have time range based affiliations, so can you show an example where it is wrong? I will debug then, otherwise it's hard to check anything othe rthan just JSON.

lukaszgryglicki commented 1 year ago

For some reason you rolls currentlky look like this:

  {
    "login": "divya-mohan0209",
    "email": "divya-mohan0209!users.noreply.github.com",
    "affiliation": "iGATE Corporation < 2015-12-01, HSBC",
    "source": "manual",
    "commits": 2301,
    "location": "Pune",
    "country_id": "in"
  },
  {
    "login": "divya-mohan0209",
    "email": "divya.mohan0209!gmail.com",
    "affiliation": "iGATE Corporation < 2015-12-01, HSBC",
    "source": "manual",
    "commits": 2301,
    "location": "Pune",
    "country_id": "in"
  },

SO they are not the same as in PR you linked - I will manually update then and next affiliations import will fix this. Possibly there was a PR later that changed this? Or they got overwritten by some bug?

lukaszgryglicki commented 1 year ago

Can you also link to DevStats instancew you want to import new affiliations? I can do it manually right after the fix if this is urgent. @divya-mohan0209

divya-mohan0209 commented 1 year ago

Thank you so much @caniszczyk for your quick help! @lukaszgryglicki : By devstats instance, I assume you mean the projects. They are K8s, Kubewarden, and k3s. However, this is not at all urgent. I just thought I should flag it because the appropriate values weren't being reflected against my current employer. Thank you so much for picking this up!

lukaszgryglicki commented 1 year ago

Ok so if not urgent then each of them will import affiliations in up to 4 weeks from now (I've fixed and updated JSON already). If you need any of them to be regenerated now - LMK, I can do this tomorrow "in the meantime".

lukaszgryglicki commented 1 year ago

I'm closing this, please LMK if you want me to do anything more on this (like manual import faster than scheduled).