search

cncf / devstats

📈CNCF-created tool for analyzing and graphing developer contributions
https://devstats.cncf.io
Apache License 2.0
61 stars 22 forks source link

[bug] when devstats score is equal for two github ids, the ranks are sorted in reverse order #40

Closed kfaseela closed 9 months ago

kfaseela commented 9 months ago

Please see the attached screenshot for the problem devstats-bug

lukaszgryglicki commented 9 months ago

I will TAL tomorrow, but this is rather about sorting by more than 1 column, from what I know you can sort by a given column in Grafana, and then other columns have random order for rows with the same value for "sort order" column - but, anyway, will inmvestigate what I can do probably tomorrow or on Monday.

kfaseela commented 9 months ago

would be nice if atleast the rank can be shown in ascending order. showing 15 first and 14 next does not look great

lukaszgryglicki commented 9 months ago

Sure, rank should actually be the same then...

lukaszgryglicki commented 9 months ago

This is WIP atm.

lukaszgryglicki commented 9 months ago

Fixed, I've updated the condition for calculating Rank value - this counts by value desc and then username/login asc (for the same value in 1st condition) - finally dashboards will be sorted by Rank asc instead of value desc.

This changes 9 dashboards on 170+ projects, so it will take some time to repopulate. Coding is done and all dashboards are being reloaded now (just thir grafana instances) - will update once more when this is done. cc @kfaseela

kfaseela commented 9 months ago

Thank you!

lukaszgryglicki commented 9 months ago

This is done, closing.