fixes escaping of img tag in nested shortcodes (#51)

cncf / dot-org-hugo-theme

Hugo theme ideal for Organizations to use. Built initially for the TODO site redesign.

https://dot-org-hugo-theme-demo.netlify.app/

MIT License

43 stars 14 forks source link

Closed cjyabraham closed 4 months ago

netlify[bot] commented 4 months ago

Name	Link
Latest commit	09e5dc77dfdfcf688eba2b1c0bdcb2654d8df415
Latest deploy log	https://app.netlify.com/sites/dot-org-hugo-theme-demo/deploys/6656d725729fa8000877dbb7
Deploy Preview	https://deploy-preview-52--dot-org-hugo-theme-demo.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 months ago

Name	Link
Latest commit	09e5dc77dfdfcf688eba2b1c0bdcb2654d8df415
Latest deploy log	https://app.netlify.com/sites/dot-org-hugo-theme-demo-thetwopct/deploys/6656d7247410900008b4054e
Deploy Preview	https://deploy-preview-52--dot-org-hugo-theme-demo-thetwopct.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thetwopct commented 4 months ago

So the problem was the indentation only? Or am I missing something.

cjyabraham commented 4 months ago

Yes, the indentation was the problem. It was causing it to enclose the <img> tag in <pre><code> tags for some reason.

thetwopct commented 4 months ago

Wow. 😂 well I guess that reiterates the conclusion from yesterday's broken urls issue.

cjyabraham commented 4 months ago

Ya, it's especially weird that it would only escape the img tag when enclosed in another shortcode. It worked fine when not enclosed.

Yes, Hugo does seem to have a lot of these pesky idiosyncrasies which can unexpectedly stymie a project.