People profile listing with map

cjyabraham commented 1 week ago

Note: the exposed Google Maps API key shows on the front-end of the site as well. It is locked down to only a select few referring urls.

netlify[bot] commented 1 week ago

Deploy Preview for dot-org-hugo-theme-demo ready!

Name	Link
Latest commit	e1f2b65f529515e46c935689c1dcd3c1833a1c49
Latest deploy log	https://app.netlify.com/sites/dot-org-hugo-theme-demo/deploys/670fab2346cd4d0008f15f88
Deploy Preview	https://deploy-preview-58--dot-org-hugo-theme-demo.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for dot-org-hugo-theme-demo-thetwopct ready!

Name	Link
Latest commit	e1f2b65f529515e46c935689c1dcd3c1833a1c49
Latest deploy log	https://app.netlify.com/sites/dot-org-hugo-theme-demo-thetwopct/deploys/670fab23f4df890008a7ab62
Deploy Preview	https://deploy-preview-58--dot-org-hugo-theme-demo-thetwopct.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cjyabraham commented 1 week ago

@thetwopct I got the map working. I'll leave it for you to style the profile cards and anything else.

cjyabraham commented 1 week ago

I went ahead and styled the profile cards, borrowing from CNCF code, so this is now ready for review.

thetwopct commented 2 days ago

I'm not overly convinced this is suitable for general inclusion in the theme. Its requirements seem very specific, and other than CNCF I've never seen a map + people layout like this used on a website. So all sites using this theme need to carry this odd component as overhead.

If it’s necessary to include, I would suggest the following:

Split out the code so its a bit more reusable (if possible within confines of Hugo) -- add a person component, which would at be useful for users who want to show staff or members (without a map); -- add a social component for displaying icons
Add details about how to use the components to the readme
Move the googlemaps script in to the theme rather than using unpkg CDN
I don't love the Google Maps key being in the config example, think it could be confusing, but then using google_maps_api_key: "{{ env 'GOOGLE_MAPS_API_KEY' }}" wouldn't be great either.

From a design perspective:

4 columns width on desktop looks pretty tight especially with that amount of text per person, 3 columns would look better
Can the job title / Company / Location be styled a bit better / closer to the name?

Before merging:

Please rebase on the latest main branch and fix merge conflicts.

Note: I've optimised the images a bit, they seemed very large for simple demo content.

cncf / dot-org-hugo-theme