search

cncf / filterable-landscape

Interactive version of the Cloud Native Landscape
https://landscape.cncf.io/
Apache License 2.0
9 stars 12 forks source link

Consider reverting virtualized scrolling #280

Closed dankohn closed 6 years ago

dankohn commented 6 years ago

https://github.com/cncf/filterable-landscape/commit/c623896ed8755fc189b015765103e21bce3f90f3 working the way you would expect in that it loads cards as you scroll.

However, we lose the immensely useful functionality of being able to type Cmd-F and "zuul" and scroll directly to that card.

Note that modern browsers already load images incrementally, which is the real bandwidth constraint. So, I think we should revert this commit.

AndreyKozlov1984 commented 6 years ago

Yes, Cmd-F is great. I could draw a simplified version of a card when it is not visible yet.

AndreyKozlov1984 commented 6 years ago

What about a mobile version? Performance issues are mostly noticeable on mobile devices, and you can not use Cmd+F there that much, at least I doubt you ever tried to search by product name on a mobile device. Should we keep virtual scrolling for mobile ?

dankohn commented 6 years ago

I don't think it's necessary, even on mobile. If you revert, we can test on some older phones. As long as we stay below 1000 cards, which is the plan, I think we should remove this.

Good to know it's feasible if we need it in the future, though.

-- Dan Kohn dan@linuxfoundation.org Executive Director, Cloud Native Computing Foundation https://www.cncf.io +1-415-233-1000 https://www.dankohn.com

On Tue, Feb 20, 2018 at 12:49 AM, Andrey Kozlov notifications@github.com wrote:

What about a mobile version? Performance issues are mostly noticeable on mobile devices, and you can not use Cmd+F there that much, at least I doubt you ever tried to search by product name on a mobile device. Should we keep virtual scrolling for mobile ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cncf/filterable-landscape/issues/280#issuecomment-366873536, or mute the thread https://github.com/notifications/unsubscribe-auth/AC8MBtbD3uX6vqg65VSBTCiQpu2ZCrJzks5tWlzdgaJpZM4SLK47 .

AndreyKozlov1984 commented 6 years ago

Ok, I've created a separate branch, so it will be easier to return this when we want to. I still want to try the virtual scroll for select popups, because they are a bit slow

AndreyKozlov1984 commented 6 years ago

Done. df122ad