search

cncf / filterable-landscape

Interactive version of the Cloud Native Landscape
https://landscape.cncf.io/
Apache License 2.0
9 stars 12 forks source link

Fatal error if missing or zero size images #310

Closed dankohn closed 6 years ago

dankohn commented 6 years ago

As with https://github.com/cncf/filterable-landscape/blob/master/src/logos/kublr.svg

Please also figure out how it got written out as null.

Compare https://github.com/cncf/filterable-landscape/blob/857efad81e7d16f3cfddf9f898100284795e455c/src/logos/kublr.svg and https://github.com/cncf/filterable-landscape/blob/c7302df8d88c45a2e7204efb9d3c7c7942c7c1df/src/logos/kublr.svg

AndreyKozlov1984 commented 6 years ago

I guess that 'null' was a result of having a try/catch inside that main try/catch. So exactly this bug should not appear again

AndreyKozlov1984 commented 6 years ago

I'm going to add a check that a file is at least 100 bytes to handle similar sort of issues in the future